Missing reasons on error message `Unable to commit directly to branch` using web editor with code:read permissions for upstream

[Nanodunkel]

Gitea Version

1.26.4

What happened?

The error message Unable to commit directly to branch because: doesn't list any reasons why this is not possible.

This happened to a user who had code:read and PR:write permissions. He forked the repo and used the web editor to edit and commit a file.

The behaviour is expected. The issue is the missing reasons on the error message.

How are you running Gitea?

Docker on Debian with default database.

[wxiaoguang]

That UI has been changed in 1.27. What does 1.27 tell you?

---

OK, maybe no difference.

The root problem is that the related code should be refactored, let backend fully prepare the messages, but not let tmpl guess.

gitea/templates/repo/editor/commit_form.tmpl

Lines 33 to 39 in 11d0ed6

	<div class="tw-mt-2">
	{{ctx.Locale.Tr "repo.editor.no_commit_to_branch"}}
	<ul class="tw-mb-0">
	{{if not .CommitFormOptions.UserCanPush}}<li>{{ctx.Locale.Tr "repo.editor.user_no_push_to_branch"}}</li>{{end}}
	{{if and .CommitFormOptions.RequireSigned (not .CommitFormOptions.WillSign)}}<li>{{ctx.Locale.Tr "repo.editor.require_signed_commit"}}</li>{{end}}
	</ul>
	</div>

[Nanodunkel]

This is how it looks with Version: 1.27.1

[wxiaoguang]

Yep, it needs a complete fix (updated in #38710 (comment))

The root problem is that the related code should be refactored, let backend fully prepare the messages, but not let tmpl guess.

[pawannn]

Hi, Can I work on this? I plan to add a CannotCommitReasons list to CommitFormOptions, fill it while checking if a user can commit, show the reasons in the template, remove the unused fields, and add one new locale message for the fork case.