NW|26-JUI-SDC|Ahmad Hmedan|Sprint 3 |Implement-shell-tools-JS - #599
Open
AhmadHmedann wants to merge 8 commits into
Open
NW|26-JUI-SDC|Ahmad Hmedan|Sprint 3 |Implement-shell-tools-JS #599AhmadHmedann wants to merge 8 commits into
AhmadHmedann wants to merge 8 commits into
Conversation
AhmadHmedann
added
the
Needs Review
Continue processing remaining files after an error. Set the process exit code to 1 if any file fails. Count zero words for empty files.
AhmadHmedann
added
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 4, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good start but there is quite a bit of work still to do.
| .name("ls ") | ||
| .description("ls implementation") | ||
| .argument("[path]", "The path to process") //zero or one path | ||
| .option("-1, --one-per-line", "one file per line") |
Contributor
There was a problem hiding this comment.
What does the -1 option do?
Author
There was a problem hiding this comment.
Thanks for the feedback. If the user adds the -1 flag, it doesn't throw an error, but in my code it doesn't have any effect.
| hadError = true; | ||
| } | ||
| } | ||
| if (paths.length > 1) { |
Contributor
There was a problem hiding this comment.
When you have multiple files, is the output well formatted?
| try { | ||
| const content = await fs.readFile(path, "utf-8"); | ||
| if (options.b) { | ||
| const lines = content.split("\n"); |
Contributor
There was a problem hiding this comment.
Is there any repetition here that can be reduced?
LonMcGregor
added
Reviewed
AhmadHmedann
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implement cat, ls, and wc CLI
Task ID: CYF-1150