NW|26-JUI-SDC|Ahmad Hmedan|Sprint 4 |Implement-shell-tools-python - #608
Open
AhmadHmedann wants to merge 5 commits into
Open
NW|26-JUI-SDC|Ahmad Hmedan|Sprint 4 |Implement-shell-tools-python#608AhmadHmedann wants to merge 5 commits into
AhmadHmedann wants to merge 5 commits into
Conversation
AhmadHmedann
changed the title
AhmadHmedann
added
the
Needs Review
LonMcGregor
reviewed
Aug 3, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Very good work, the files are very neat and well written. Just one minor suggestion to improve
| print(" ".join(map(str, results.values())), path) | ||
|
|
||
| if len(paths) > 1: | ||
| print(" ".join(map(str, total_results.values())), "total") |
Contributor
There was a problem hiding this comment.
If you print multiple files, how does the output look? Is there a change that could make it neater?
Author
There was a problem hiding this comment.
Thanks for the feedback! I hope I've addressed your question.
LonMcGregor
added
Reviewed
AhmadHmedann
added
Needs Review
LonMcGregor
reviewed
Aug 4, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Much better - the output will be formatted more neatly here
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implement cat, ls, and wc CLI
Task ID: CYF-1152