London | 26-SDC-July | Kris Oldrini | Sprint 3 | Implement shell tools - #611
Open
XiaoQuark wants to merge 7 commits into
Open
London | 26-SDC-July | Kris Oldrini | Sprint 3 | Implement shell tools#611XiaoQuark wants to merge 7 commits into
XiaoQuark wants to merge 7 commits into
Conversation
XiaoQuark
added
the
Needs Review
XiaoQuark
added
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 4, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good work on these tasks, well organised code.I have some questions for you to push further
| @@ -0,0 +1,53 @@ | |||
| import process from "node:process"; | |||
| import { promises as fs } from "node:fs"; | |||
| import { Command } from "commander"; | |||
Contributor
There was a problem hiding this comment.
Is there a way you can get a program from commander directly?
| import process from "node:process"; | ||
| import fs, { truncate } from "node:fs"; | ||
|
|
||
| const argv = process.argv.slice(2); |
Contributor
There was a problem hiding this comment.
is there a reason you don't use the commander or parseargs api here?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
cat,lsandwcimplementation in JavaScript.Task ID: CYF-1150