Glasgow | 26-SDC-JUL | Mirabelle Morah | Sprint 3 | Implement Shell Tools - #620
Open
mirabellemorah wants to merge 1 commit into
Open
Glasgow | 26-SDC-JUL | Mirabelle Morah | Sprint 3 | Implement Shell Tools#620mirabellemorah wants to merge 1 commit into
mirabellemorah wants to merge 1 commit into
Conversation
mirabellemorah
added
📅 Sprint 3
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
mirabellemorah
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
mirabellemorah
changed the title
mirabellemorah
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 4, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good start but there is quite a bit of work still to do.
| if (i === lines.length - 1 && line === "") { | ||
| break; | ||
| } | ||
| const prefix = calculatePrefix( |
Contributor
There was a problem hiding this comment.
Is running calculatePrefix for every line of output an efficient solution?
| import { promises as fs } from "node:fs"; | ||
| import process from "node:process"; | ||
|
|
||
| const argv = process.argv.slice(2); |
Contributor
There was a problem hiding this comment.
Is there a reason you used commander in the cat example, but not here
| } | ||
| } | ||
|
|
||
| const showOnePerLine = flags.includes("-1"); |
Contributor
There was a problem hiding this comment.
What does the showOnePerLine const do?
| import { program } from "commander"; | ||
| import { promises as fs } from "node:fs"; | ||
|
|
||
| const argv = process.argv.slice(2); |
Contributor
There was a problem hiding this comment.
You import the commander program api, but don't use it. Is there a reason for that?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Used node to implement shell command lines
Task ID: CYF-1150