[SPARK-58559][PYTHON] Package all of sbin in PySpark classic distribution - #57763
Open
nchammas wants to merge 1 commit into
Open
[SPARK-58559][PYTHON] Package all of sbin in PySpark classic distribution#57763nchammas wants to merge 1 commit into
nchammas wants to merge 1 commit into
Conversation
nchammas
marked this pull request as ready for review
August 4, 2026 13:49
Contributor
Author
HyukjinKwon
reviewed
Aug 4, 2026
| "stop-connect-server.sh", | ||
| "stop-history-server.sh", | ||
| ], | ||
| "pyspark.sbin": ["*"], |
Member
There was a problem hiding this comment.
I think the problem was that we wanted to avoid for users to use pip installed pyspark to start a cluster or sth. what scripts do we include?
Contributor
Author
There was a problem hiding this comment.
Yes, we wanted to prevent users from using PySpark to start a standalone cluster. I tried to address this with a clearer README so that we can just package everything. In other words, I think it's easier to control this via our support policy instead of via "hard" packaging changes.
Switching to * means we will package sbin/start-{thriftserver, master, worker}.sh in addition to the existing scripts we are already packaging today. These newly packaged scripts can also be called by the new CLI if/when we merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Package everything in
sbin/when building a PySpark Classic distribution.Why are the changes needed?
Some
sbinscripts were first added to PySpark in #23715. There was some disagreement then about whether PySpark should include these scripts, mainly because some committers at the time thought PySpark should be a client-only distribution.In the intervening years, the Spark Connect effort has created a true client-only distribution of Spark in contrast to the "heavier" PySpark Classic which includes all of Spark's assembly JARs.
PySpark Classic has included some
sbinscripts since 3.0.0, and #56907 recently added the Connect server scripts. #56907, however, neglected to add the corresponding directives toMANIFEST.in.Since #57452 clarifies the intended use of the Python distributions of Spark -- specifically, that starting a full cluster is not supported, regardless of whether it's possible -- I believe it's conceptually simpler to just package all of
sbin. That would, for example, prevent the kind of gap identified in #56907.Does this PR introduce any user-facing change?
Yes, it packages additional
sbinscripts in the PySpark classic distribution.How was this patch tested?
Distributions are not tested thoroughly. #57645 adds a dedicated distribution validation script. I think we should discuss there any testing we would like to add for this.
Was this patch authored or co-authored using generative AI tooling?
No.