[Rust] Allow to supply a default string value - #5562
Open
kistz wants to merge 60 commits into
Open
Conversation
Contributor
Author
|
@gefjon could you take a look at this? :> |
2 tasks
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
…fault-tests' of github.com:clockworklabs/SpacetimeDB into bfops/consolidate-default-tests
Collaborator
|
Regardless of the order of PR merges, I think the tests in #5618 are the best coverage for this, so I had the bot revert the test changes. Other than that, I'm fine to merge in any order if you want to move this out of draft. |
# Description of Changes Fixes clockworklabs#5623 Fixes clockworklabs#5624 Fixes clockworklabs#5627 Fixes clockworklabs#5622 # API and ABI breaking changes No. Fixes bugs with things that won't working (two build failures, one publish failure, and one incorrect default value) # Expected complexity level and risk 2 # Testing - [x] Further smoketest cases have been enabled - [x] modules in those smoketests are building and publishing successfully --------- Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com> Co-authored-by: clockwork-labs-bot <clockwork-labs-bot@users.noreply.github.com>
Contributor
Author
kistz
marked this pull request as ready for review
July 31, 2026 12:02
gefjon
approved these changes
Aug 3, 2026
pull Bot
pushed a commit
to Abaso007/SpacetimeDB
that referenced
this pull request
Aug 4, 2026
# Description of Changes Motivated by clockworklabs#5562, this PR adds smoketests for default column values in all suported languages. This uncovered multiple bugs: - clockworklabs#5622 - clockworklabs#5623 - clockworklabs#5624 - clockworklabs#5627 # API and ABI breaking changes None. New tests only. # Expected complexity level and risk 2 # Testing - [x] CI passes - [x] CI correctly failed on broken default values --------- Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com> Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com> Co-authored-by: clockwork-labs-bot <clockwork-labs-bot@users.noreply.github.com>
bfops
enabled auto-merge
August 4, 2026 16:42
# Conflicts: # crates/bindings-macro/src/table.rs # crates/smoketests/tests/smoketests/column_defaults.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Rust modules cannot do it at the moment.
Allow it by taking in a
&'static str.The approach in the macro is safe because we always have a
std::Stringenforeced by theSpacetimeTypeimplementation.API and ABI breaking changes
None. Additive changes
TODO: Update the documentation aswell if approach is good enough.
Expected complexity level and risk
1
Testing