Fix targeted custom-linter findings outside function-length backlog by Copilot · Pull Request #50177 · github/gh-aw

Copilot · 2026-08-04T05:01:28Z

make golint-custom reported six findings unrelated to the shared function-length backlog: two functions one line over the 60-line limit, one sort.Slice, two loop string concatenations, and one len(s) > 0 emptiness check. Each is addressed with a minimal, local edit.

Function length (61 → under limit)

pkg/parser/import_field_extractor.go: moved the six MergedMax* assignments out of the ImportsResult literal into a small applyMergedLimits method.
pkg/linters/sortslice/sortslice.go: extracted the selector/package resolution chain in run into sortPackageSelector.

Type-safe sorting

pkg/cli/compile_pipeline.go: sort.Slice → slices.SortFunc; the sort import is dropped in favor of slices.

slices.SortFunc(features, func(a, b featureCount) int {
    if a.count != b.count {
        return b.count - a.count
    }
    return strings.Compare(a.name, b.name)
})

Loop concatenation → `strings.Builder`

pkg/workflow/copilot_engine_execution.go: heredoc delimiter escalation loop.
pkg/cli/mcp_tools_readonly.go: shellcheck diagnostic accumulator; current becomes a builder, with current.Len() > 0 replacing the current != "" guards and Reset() on flush.

Misc

pkg/workflow/copilot_logs.go: len(content.Content) > 0 → content.Content != "".
pkg/ctxutil/ctxutil.go: //nolint:ctxbackground on OrBackground, whose sole purpose is to centralize the context.Background() fallback — the linter cannot distinguish the definition from its misuse.

Remaining golint-custom output is limited to the pre-existing function-length backlog.

Fixes [lint-monster] lint-monster: fix targeted custom-linter findings outside function-length backlog #50163

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 3.69 AIC · ⌖ 5.78 AIC · ⊞ 8.3K · ◷
_{Comment /souschef to run again}

Run: https://github.com/github/gh-aw/actions/runs/30886362119

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 4.67 AIC · ⌖ 4.74 AIC · ⊞ 8.3K · ◷
_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 5.43 AIC · ⌖ 5.88 AIC · ⊞ 8.3K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-08-04T05:17:39Z

@copilot resolve the merge conflicts on this branch.

Copilot

Pull request overview

Resolves targeted custom-linter findings through small, behavior-preserving Go refactors.

Changes:

Extracts helpers to satisfy function-length limits.
Replaces unsafe sorting and loop concatenation patterns.
Applies targeted lint-compliant checks and suppression.

Show a summary per file

File	Description
`pkg/cli/compile_pipeline.go`	Uses type-safe feature sorting.
`pkg/cli/mcp_tools_readonly.go`	Builds diagnostics with `strings.Builder`.
`pkg/ctxutil/ctxutil.go`	Documents intentional background-context fallback.
`pkg/linters/sortslice/sortslice.go`	Extracts sort package resolution.
`pkg/parser/import_field_extractor.go`	Extracts merged-limit assignments.
`pkg/workflow/copilot_engine_execution.go`	Builds heredoc delimiters efficiently.
`pkg/workflow/copilot_logs.go`	Uses an idiomatic string emptiness check.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 7/7 changed files
Comments generated: 0
Review effort level: Balanced

gh-aw-bot · 2026-08-04T06:11:16Z

@copilot This PR needs a quick maintainer-ready refresh.

Please update the branch with the latest base changes.
Then run the pr-finisher skill and address any remaining feedback before handing back.

Run: https://github.com/github/gh-aw/actions/runs/30882770542

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 3.69 AIC · ⌖ 5.78 AIC · ⊞ 8.3K · ◷
_{Comment /souschef to run again}

gh-aw-bot · 2026-08-04T07:12:18Z

@copilot This PR needs a quick maintainer-ready refresh.

Please update the branch with the latest base changes.
Then run the pr-finisher skill and address any remaining feedback before handing back.

Run: https://github.com/github/gh-aw/actions/runs/30886362119

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 4.67 AIC · ⌖ 4.74 AIC · ⊞ 8.3K · ◷
_{Comment /souschef to run again}

github-actions · 2026-08-04T07:15:03Z

Triage: refactor / medium risk

Category: refactor
Risk: medium
Priority score: 35/100 (impact 20, urgency 10, quality 5)
Recommended action: defer — not mergeable (dirty/conflicting), CI copilot checks failing (2x failure)
Notes: Targeted lint-finding fixes across 7 files (sort.Slice→slices.SortFunc, string-builder loops, function-length reductions). Needs rebase and CI fix before further review.

Generated by 🔧 PR Triage Agent · auto · 28.5 AIC · ⌖ 2.46 AIC · ⊞ 8K · ◷

gh-aw-bot · 2026-08-04T08:07:22Z

@copilot This PR needs a quick maintainer-ready refresh.

Please update the branch with the latest base changes.
Then run the pr-finisher skill and address any remaining feedback before handing back.

Run: https://github.com/github/gh-aw/actions/runs/30890137680

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 5.43 AIC · ⌖ 5.88 AIC · ⊞ 8.3K · ◷
_{Comment /souschef to run again}

gh-aw-bot · 2026-08-04T11:09:42Z

@copilot This PR has merge conflicts and needs a maintainer-ready refresh.

Please run make merge-main to resolve the conflicts on this branch.
Then run the pr-finisher skill, address any remaining review or CI issues, and hand back when ready.

Run: https://github.com/github/gh-aw/actions/runs/30903169885

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 12.2 AIC · ⌖ 8.95 AIC · ⊞ 8.3K · ◷
_{Comment /souschef to run again}

pelikhan · 2026-08-04T11:55:58Z

@copilot resolve the merge conflicts on this branch.

pelikhan · 2026-08-04T12:21:18Z

@copilot merge main and recompile.

Do not use agentfinder

gh-aw-bot · 2026-08-04T12:37:03Z

Caution

agentic threat detected
Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.

Details

Potential security threats were detected in the agent output.

Review the workflow run logs for details.

@copilot This PR has merge conflicts and needs a maintainer-ready refresh.

Please run make merge-main to resolve the conflicts on this branch.
Then run the pr-finisher skill, address any remaining review or CI issues, and hand back when ready.

Run: https://github.com/github/gh-aw/actions/runs/30909334614

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 11.8 AIC · ⌖ 11.3 AIC · ⊞ 8.3K · ◷
_{Comment /souschef to run again}

pelikhan · 2026-08-04T12:40:28Z

@copilot resolve the merge conflicts on this branch.

github-actions · 2026-08-04T12:57:26Z

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection results could not be parsed.

Review the workflow run logs for details.

Triage update: refactor / medium risk

Category: refactor
Risk: medium (unchanged)
Score: 28 (impact 10 + urgency 8 + quality 10)
Recommended action: defer — mergeable_state dirty, repeated merge-conflict refresh requests unresolved, all copilot check-runs failing. Lower priority until conflicts are resolved.

Generated by 🔧 PR Triage Agent · auto · 29.9 AIC · ⌖ 2.62 AIC · ⊞ 8K · ◷

gh-aw-bot · 2026-08-04T13:22:16Z

@copilot This PR has merge conflicts and needs a maintainer-ready refresh.

Please run make merge-main to resolve the conflicts on this branch.
Then run the pr-finisher skill, address any remaining review or CI issues, and hand back when ready.

Run: https://github.com/github/gh-aw/actions/runs/30912825871

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 18.4 AIC · ⌖ 7.69 AIC · ⊞ 5.9K · ◷
_{Comment /souschef to run again}

Initial plan

1752410

Copilot AI assigned Copilot and pelikhan Aug 4, 2026

Copilot started work on behalf of pelikhan August 4, 2026 05:02 View session

Copilot AI linked an issue Aug 4, 2026 that may be closed by this pull request

[lint-monster] lint-monster: fix targeted custom-linter findings outside function-length backlog #50163

Open

6 tasks

Fix targeted custom-linter findings outside function-length backlog

5ed0f34

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix custom linter findings outside function-length backlog~~ Fix targeted custom-linter findings outside function-length backlog Aug 4, 2026

Copilot finished work on behalf of pelikhan August 4, 2026 05:14

Copilot AI requested a review from pelikhan August 4, 2026 05:14

pelikhan marked this pull request as ready for review August 4, 2026 05:17

Copilot AI balanced review requested due to automatic review settings August 4, 2026 05:17

Copilot started reviewing on behalf of pelikhan August 4, 2026 05:18 View session

Copilot AI reviewed Aug 4, 2026

View reviewed changes

Copilot started work on behalf of pelikhan August 4, 2026 05:20 View session

Copilot stopped work on behalf of pelikhan due to an error August 4, 2026 05:36
Copilot stopped unexpectedly while processing your request.

github-actions Bot mentioned this pull request Aug 4, 2026

[pr-sous-chef] PR Sous Chef run report #50117

Open

Copilot started work on behalf of gh-aw-bot August 4, 2026 06:11 View session

Copilot stopped work on behalf of gh-aw-bot due to an error August 4, 2026 06:29
Copilot stopped unexpectedly while processing your request.

Copilot AI requested a review from gh-aw-bot August 4, 2026 06:29

Copilot started work on behalf of gh-aw-bot August 4, 2026 07:13 View session

github-actions Bot added pr-action:defer pr-agent:copilot pr-priority:medium pr-risk:medium pr-type:refactor labels Aug 4, 2026

Copilot stopped work on behalf of gh-aw-bot due to an error August 4, 2026 07:29
Copilot stopped unexpectedly while processing your request.

Copilot started work on behalf of gh-aw-bot August 4, 2026 08:08 View session

Copilot stopped work on behalf of gh-aw-bot due to an error August 4, 2026 08:25
Copilot stopped unexpectedly while processing your request.

Copilot started work on behalf of gh-aw-bot August 4, 2026 11:10 View session

Copilot stopped work on behalf of gh-aw-bot due to an error August 4, 2026 11:32
Copilot stopped unexpectedly while processing your request.

Copilot started work on behalf of pelikhan August 4, 2026 11:56 View session

Copilot stopped work on behalf of pelikhan due to an error August 4, 2026 12:12
Copilot stopped unexpectedly while processing your request.

Copilot started work on behalf of pelikhan August 4, 2026 12:21 View session

Copilot stopped work on behalf of pelikhan due to an error August 4, 2026 12:37
Copilot stopped unexpectedly while processing your request.

Copilot started work on behalf of gh-aw-bot August 4, 2026 12:37 View session

Copilot stopped work on behalf of gh-aw-bot due to an error August 4, 2026 12:57
Copilot stopped unexpectedly while processing your request.

Copilot started work on behalf of pelikhan August 4, 2026 13:00 View session

Copilot stopped work on behalf of pelikhan due to an error August 4, 2026 13:08
Copilot stopped unexpectedly while processing your request.

Copilot started work on behalf of gh-aw-bot August 4, 2026 13:23 View session

Copilot stopped work on behalf of gh-aw-bot due to an error August 4, 2026 13:41
Copilot stopped unexpectedly while processing your request.

Uh oh!

Conversation

Copilot AI commented Aug 4, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Function length (61 → under limit)

Type-safe sorting

Loop concatenation → strings.Builder

Misc

Uh oh!

pelikhan commented Aug 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

gh-aw-bot commented Aug 4, 2026

Uh oh!

gh-aw-bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Triage: refactor / medium risk

Uh oh!

gh-aw-bot commented Aug 4, 2026

Uh oh!

gh-aw-bot commented Aug 4, 2026

Uh oh!

pelikhan commented Aug 4, 2026

Uh oh!

pelikhan commented Aug 4, 2026

Uh oh!

gh-aw-bot commented Aug 4, 2026

Uh oh!

pelikhan commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Triage update: refactor / medium risk

Uh oh!

gh-aw-bot commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Aug 4, 2026 •

edited by github-actions Bot

Loading

Loop concatenation → `strings.Builder`