CHORE: Migrate Linux container image references from ACR to GHCR - #696
Open
saurabh500 wants to merge 3 commits into
Open
CHORE: Migrate Linux container image references from ACR to GHCR#696saurabh500 wants to merge 3 commits into
saurabh500 wants to merge 3 commits into
Conversation
Point the Linux build, ODBC build, and wheel-installation-test stages at the public GHCR images published by github.com/microsoft/mssql-rs instead of the tdslibrs.azurecr.io mirrors. - tdslibrs.azurecr.io/import/python-build/manylinux_2_28_<arch>:latest -> ghcr.io/microsoft/mssql-rs/python-build/manylinux_2_28_<arch>_rust:latest - tdslibrs.azurecr.io/import/python-build/musllinux_1_2_<arch>:latest -> ghcr.io/microsoft/mssql-rs/python-build/musllinux_1_2_<arch>_rust:latest The GHCR packages are public, so the AzureCLI 'az acr login --name tdslibrs' steps (and their dependency on the 'Magnitude Test-mssql-rs-mssql-python' service connection) are no longer needed and are removed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a6965bb-277d-4969-b0d1-7d38eae70a5d
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.pybind.ddbc_bindings.h: 59.9%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.ddbc_bindings.cpp: 76.2%
mssql_python.__init__.py: 77.3%
mssql_python.row.py: 77.6%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection_pool.cpp: 81.4%
mssql_python.pybind.connection.connection.cpp: 83.7%
mssql_python.connection.py: 84.7%🔗 Quick Links
|
The vanilla PyPA base images are now mirrored to GHCR alongside the _rust variants, so point at those instead for an exact 1:1 match with the ACR paths they replace (no unused Rust toolchain in the build/test containers). ghcr.io/microsoft/mssql-rs/import/python-build/manylinux_2_28_<arch>:latest ghcr.io/microsoft/mssql-rs/import/python-build/musllinux_1_2_<arch>:latest Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5a6965bb-277d-4969-b0d1-7d38eae70a5d
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the OneBranch Linux CI stages to pull their PyPA base container images from public GitHub Container Registry (GHCR) packages published by microsoft/mssql-rs, replacing the previous private Azure Container Registry (ACR) mirror and removing the associated ACR login steps.
Changes:
- Switched Linux container image references from
tdslibrs.azurecr.io/...toghcr.io/microsoft/mssql-rs/...for both manylinux_2_28 and musllinux_1_2 images (x86_64/aarch64). - Removed
AzureCLI@2ACR login steps (no longer needed for public GHCR pulls). - Updated inline comments to reflect the new image source and anonymous pull behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| OneBranchPipelines/stages/build-linux-single-stage.yml | Removes ACR login and updates the build container image reference to GHCR. |
| OneBranchPipelines/stages/build-odbc-linux-stage.yml | Removes ACR login and updates the ODBC build container image reference to GHCR. |
| OneBranchPipelines/stages/wheel-installation-test-stage.yml | Removes ACR login and updates the wheel installation test container image reference to GHCR. |
jahnvi480
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#699
Summary
Migrates the Linux container images used by the OneBranch pipelines off
tdslibrs.azurecr.ioand onto the public GHCR packages published by github.com/microsoft/mssql-rs.Image mapping (exact 1:1 with the ACR paths they replace):
tdslibrs.azurecr.io/import/python-build/manylinux_2_28_<arch>:latestghcr.io/microsoft/mssql-rs/import/python-build/manylinux_2_28_<arch>:latesttdslibrs.azurecr.io/import/python-build/musllinux_1_2_<arch>:latestghcr.io/microsoft/mssql-rs/import/python-build/musllinux_1_2_<arch>:latestFiles changed:
OneBranchPipelines/stages/build-linux-single-stage.ymlOneBranchPipelines/stages/build-odbc-linux-stage.ymlOneBranchPipelines/stages/wheel-installation-test-stage.ymlAlso removes the three
AzureCLI@2"Login to ACR (tdslibrs)" steps — the GHCR packages are public, so pulls are anonymous and theMagnitude Test-mssql-rs-mssql-pythonservice connection is no longer needed for image access.Notes for reviewers
$(ARCH)already resolves tox86_64/aarch64, which matches the GHCR tag naming exactly.manylinux_2_28_{x86_64,aarch64}:latestandmusllinux_1_2_{x86_64,aarch64}:latest).