[FND-188] Implement services / dialog to preview changes when switching variants - #24589
Draft
dfriquet wants to merge 6 commits into
Conversation
The preview was a POST verb hanging off an otherwise resourceful route. It is now ImpactsController#create on switch/impact, which keeps the POST the shared refresh mechanism requires while naming the thing it renders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/FND-188
What are you trying to accomplish?
Tells the administrator what switching a project's type variant will do, before they apply it.
Stacked on the FND-198 branch. Base it back to
devonce that merges.Screenshots
What approach did you choose and why?
Projects::Types::Switch::Impactis a plain query object, not a service: nothing mutates, so validation,on_success/on_failureand a persist step would all go unused. Five queries, independent of work package count.SwitchFieldsComponent.Merge checklist