Skip to content

docs: clarify prCreation=not-pending fallback and no-check caveat - #44889

Open
RahulGautamSingh wants to merge 1 commit into
renovatebot:mainfrom
RahulGautamSingh:docs/prcreation-not-pending-caveat
Open

docs: clarify prCreation=not-pending fallback and no-check caveat#44889
RahulGautamSingh wants to merge 1 commit into
renovatebot:mainfrom
RahulGautamSingh:docs/prcreation-not-pending-caveat

Conversation

@RahulGautamSingh

@RahulGautamSingh RahulGautamSingh commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Changes

Documents the prCreation=not-pending behavior discussed in #44161:

  • Correct the fallback timeout from "24 hours" to the actual prNotPendingHours default of 25 hours, and link the option (both in the prCreation section and the automergeType=branch backup-PR note).
  • Note that the fallback is measured from the branch's latest commit, so rebases/re-locks reset the timer.
  • Warn that not-pending can stall PR creation when branches have no external checks (e.g. CI only on pull_request), and point to internalChecksAsSuccess=true / prCreation=immediate as fixes.
  • Add the same caveat to the "Suppress branch/PR creation for X days" example.

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation). Docs drafted with Claude (Opus 4.8); figures verified against lib/config/options/index.ts and lib/workers/repository/update/pr/index.ts.
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

@github-actions
github-actions Bot requested a review from viceice July 27, 2026 16:55
@klippx

klippx commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Only one suggestion:

In the original issue I mentioned that

The docs at Suppress branch/PR creation for x days recommend this combo to hold updates for a few days:

 {
   "minimumReleaseAge": "3 days",
   "internalChecksFilter": "strict",
   "prCreation": "not-pending"
 }

I think that maybe this needs to be updated (adding "internalChecksAsSuccess": true ?)- or at least something need to mentioned immediately close to this "official recommendation", because it was this mis-recommendation that caused all our suffering.

@RahulGautamSingh

Copy link
Copy Markdown
Collaborator Author

or at least something need to mentioned immediately close to this "official recommendation"

Already done, pleas recheck the changes/additions in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants