Skip to content

fix(github): recognize another "needs approving review" message - #45052

Open
amezin wants to merge 1 commit into
renovatebot:mainfrom
amezin:pr-merge
Open

fix(github): recognize another "needs approving review" message#45052
amezin wants to merge 1 commit into
renovatebot:mainfrom
amezin:pr-merge

Conversation

@amezin

@amezin amezin commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Changes

Recognize "New changes require approval from someone other than the last pusher" as another error message indicating that the PR requires an approval. Stops Renovate from unnecessary attempts to merge the pull request with different methods.

"response": {
  "message": "Repository rule violations found\n\nNew changes require approval from someone other than the last pusher.\n\n",
  "documentation_url": "https://docs.github.com/rest/pulls/pulls#merge-a-pull-request",
  "status": "405"
}

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Use of AI in replying to PR comments

Who answers review comments:

  • @amezin will read and reply directly.
  • An agent will draft replies and @username will read them before they are posted. Name the account.
  • Nobody has explicitly committed to replying.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

    "response": {
      "message": "Repository rule violations found\n\nNew changes require approval from someone other than the last pusher.\n\n",
      "documentation_url": "https://docs.github.com/rest/pulls/pulls#merge-a-pull-request",
      "status": "405"
    }
@github-actions
github-actions Bot requested a review from viceice August 4, 2026 07:35

@jamietanna jamietanna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants