Fail instead of warning when frozen mode can't update the lockfile - #9750
Open
hsbt wants to merge 2 commits into
Open
Fail instead of warning when frozen mode can't update the lockfile#9750hsbt wants to merge 2 commits into
hsbt wants to merge 2 commits into
Conversation
bundle install and bundle check in frozen mode printed "Cannot write a changed lockfile while frozen." to stderr and exited 0 when regenerating the lockfile would change it, so invalid lockfiles went unnoticed in CI. Raise ProductionError instead. To avoid failing on environment-only differences, ignore BUNDLED WITH even across bundler major versions and reproduce the locked bundler CHECKSUMS entry instead of recording one for the running bundler version. #9549 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
These lockfiles deviated from the canonical form bundler generates (a missing or extra trailing slash on the source remote, unsorted GEM and DEPENDENCIES entries), so frozen mode used to print a warning and keep going. Now that a changed lockfile raises in frozen mode, align them with what bundler actually writes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
hsbt
force-pushed
the
claude/rubygems-issue-9549-d50efa
branch
from
August 4, 2026 01:56
e1ecc67 to
2a2b5cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bundle installandbundle checkin frozen mode printedCannot write a changed lockfile while frozen.to stderr and exited 0 when regenerating the lockfile would change it, so invalid lockfiles went unnoticed in CI. This makeswrite_lockraiseProductionErrorinstead. To avoid failing on environment-only differences, the frozen comparison now ignoresBUNDLED WITHeven across bundler major versions, and the lockfile generator reproduces the locked bundlerCHECKSUMSentry instead of recording one for the running bundler version, so deploys running a different bundler version than the one that generated the lockfile keep working. A bundler checksum entry that contradictsBUNDLED WITHstill fails. This complements #9715, which catches drift visible toensure_equivalent_gemfile_and_lockfile. The cases caught here are canonical-form differences such as the out-of-order orphan entries from the report.Fixes #9549