Skip to content

Fix: WF ICE assumptions on binders - #160497

Open
ssenthilnathan3 wants to merge 1 commit into
rust-lang:mainfrom
ssenthilnathan3:fix/wf-ice-assumptions-on-binders
Open

Fix: WF ICE assumptions on binders#160497
ssenthilnathan3 wants to merge 1 commit into
rust-lang:mainfrom
ssenthilnathan3:fix/wf-ice-assumptions-on-binders

Conversation

@ssenthilnathan3

@ssenthilnathan3 ssenthilnathan3 commented Aug 4, 2026

Copy link
Copy Markdown

Fixes #160293

-Zassumptions-on-binders ICEs because the solver's well_formed_goals passes terms with resolvable inference variables to unnormalized_obligations, which asserts they're already resolved (unlike other callers).

Resolve inference variables before computing WF obligations.

@rustbot

rustbot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 4, 2026
@rustbot

rustbot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @adwinwhite (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 21 candidates

@rustbot

This comment has been minimized.

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2026
@ssenthilnathan3 ssenthilnathan3 changed the title Fixes wf ICE assumptions on binders Fix: WF ICE assumptions on binders Aug 4, 2026
@ssenthilnathan3
ssenthilnathan3 force-pushed the fix/wf-ice-assumptions-on-binders branch from aefa84f to 5b7244d Compare August 4, 2026 09:43
@rustbot rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: Term != Term

4 participants