Same description for crate and pathroot - #160500
Open
bb1yd wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mejrs rustbot has assigned @mejrs. Use Why was this reviewer chosen?The reviewer was selected based on:
|
bb1yd
force-pushed
the
same-message-for-crate-and-pathroot
branch
from
August 4, 2026 11:53
c6fb263 to
f132d8f
Compare
bb1yd
force-pushed
the
same-message-for-crate-and-pathroot
branch
from
August 4, 2026 12:57
f132d8f to
b5507ea
Compare
bjorn3
reviewed
Aug 4, 2026
| [.., prev] => { | ||
| if prev.ident.name == kw::PathRoot { | ||
| if prev.ident.name == kw::PathRoot || prev.ident.name == kw::Crate { | ||
| format!("the crate root") |
Member
There was a problem hiding this comment.
There is a difference between :: (kw::PathRoot) and crate (kw::Crate). The former refers to the extern prelude (which contains --extern deps) since the 2018 edition, while the latter only refers to the root of the crate just like the former could have in the 2015 edition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as https://github.com/bb1yd/rust/blob/8ab9fdff5a91b9f2b5ed57fb0275452d9a0d0280/compiler/rustc_resolve/src/diagnostics/impls.rs#L3027-L3035