feat(code): cli sandboxes, enterprise timeouts, secrets projections, resolver lift, workflow exec cancellations - #6247
feat(code): cli sandboxes, enterprise timeouts, secrets projections, resolver lift, workflow exec cancellations#6247icecrasher321 wants to merge 17 commits into
Conversation
…lver # Conflicts: # apps/sim/components/settings/navigation.test.ts # apps/sim/components/settings/navigation.ts # apps/sim/providers/index.test.ts
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 35640005 | Triggered | Generic Password | 1a7c79b | apps/desktop/src/main/browser-import/import-service.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryHigh Risk Overview Function execution gains Shell as a remote language, Python as real modules ( A central code compiler/resolver now binds Async workflow policy: Enterprise can configure longer runs (up to 7 days); direct async API/SDK callers may send Stale execution cleanup is reworked for scale: deadline-aware workflow failure, bounded batched mutations with Reviewed by Cursor Bugbot for commit 5cbafee. Configure here. |
Greptile SummaryThis PR centralizes execution-time placeholder and secret resolution while expanding sandbox capabilities and configurable enterprise execution deadlines.
Confidence Score: 5/5The PR appears safe to merge based on the review findings available in this follow-up. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/executor/variables/resolver.ts | Centralizes execution input and secret-reference resolution for block handlers. |
| apps/sim/lib/execution/code-placeholders/index.ts | Exposes the shared compiler contract for language-aware code placeholders. |
| apps/sim/lib/execution/remote-sandbox/cli-tools.server.ts | Defines server-only, pinned installation recipes for curated sandbox CLIs. |
| apps/sim/lib/execution/remote-sandbox/resolve.ts | Resolves sandbox specifications, packages, managed CLIs, and provider behavior. |
| apps/sim/lib/billing/execution-timeout-defaults.ts | Introduces centralized defaults and policy handling for execution timeouts. |
| apps/sim/app/api/workflows/[id]/execute/route.ts | Propagates request-level asynchronous execution deadlines through workflow admission and dispatch. |
| packages/db/schema.ts | Extends persisted enterprise metadata needed by configurable execution policies. |
| packages/ts-sdk/src/index.ts | Adds the asynchronous server-side execution timeout option to the TypeScript SDK. |
| packages/python-sdk/simstudio/init.py | Adds the corresponding asynchronous execution timeout option to the Python SDK. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Trigger[Workflow trigger] --> Preprocess[Admission and timeout policy]
Preprocess --> Resolver[Central variable and secret resolver]
Resolver --> Executor[Workflow executor]
Executor --> Function[Function sandbox]
Function --> Runtime{Runtime}
Runtime --> JavaScript[JavaScript]
Runtime --> Python[Python]
Runtime --> Shell[Shell]
Function --> ManagedCLI[Managed CLI environment]
Executor --> Projection[Secret-safe output projection]
Projection --> Logs[Logs and traces]
Projection --> Agent[Agent and Copilot consumers]
Reviews (12): Last reviewed commit: "Merge remote-tracking branch 'origin/sta..." | Re-trigger Greptile
|
@cursor review |
|
@cursor review |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6a257db. Configure here.
…lver # Conflicts: # apps/sim/background/schedule-execution.test.ts # apps/sim/background/schedule-execution.ts # apps/sim/lib/copilot/chat/workspace-context.ts
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 93c6320. Configure here.
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7845110. Configure here.
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 54e828f. Configure here.
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 9f0d229. Configure here.
…lver # Conflicts: # apps/sim/lib/copilot/vfs/workspace-vfs.ts # apps/sim/lib/core/config/env-flags.ts # apps/sim/lib/execution/remote-sandbox/pi-lifetime.test.ts # apps/sim/lib/execution/remote-sandbox/pi-lifetime.ts # apps/sim/lib/execution/remote-sandbox/provider.ts # scripts/setup/checks.ts
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 5cbafee. Configure here.
Summary
Type of Change
Testing
Tested manually
Checklist