Skip to content

docs: add asm type annotations across constants packages - #13915

Open
Planeshifter wants to merge 1 commit into
developfrom
philipp/fix-propagation-2026-08-04
Open

docs: add asm type annotations across constants packages#13915
Planeshifter wants to merge 1 commit into
developfrom
philipp/fix-propagation-2026-08-04

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • propagates fixes merged to develop between 2026-08-03T17:46-07:00 and 2026-08-04T00:05-07:00 to sibling packages.

Adds the // asm type annotation trailing comment to the six remaining coerced-integer constants that lacked it, bringing the constants namespace to full coverage (77 of 77 non-eslint-disable-line sites). Purely mechanical: appends the existing convention established in ab689bf (#13905) to lines it missed on first pass; no coercion logic changes.

  • constants/float16/abs-mask
  • constants/float16/num-exponent-bits
  • constants/float16/num-significand-bits
  • constants/float16/sign-mask
  • constants/float32/abs-mask
  • constants/float32/sign-mask

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation: candidate sites were enumerated by searching lib/node_modules/@stdlib/constants/**/lib/*.js for bare |0/>>>0 coercions (92 total coercion sites: 77 annotated, 9 carrying // eslint-disable-line id-length, 6 bare). Each of the six sites was independently confirmed by two validation passes, an adaptation pass (verbatim applicability, ESLint max-len/id-length interaction ruled out), and a style-consistency pass against the existing 77 annotated sites. Deliberately excluded: the nine sites whose trailing-comment slot is occupied by // eslint-disable-line id-length (identifiers longer than 25 characters), and uncoerced plain hex-literal constants (e.g. constants/float16/exponent-mask).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code as part of an automated fix-propagation routine: candidate sites were enumerated via search and validated by independent review passes before the changes were applied.


@stdlib-js/reviewers

🤖 Generated with Claude Code

https://claude.ai/code/session_01EPpEJXtCEJjRk6CrC8bZv9


Generated by Claude Code

Propagates fix from ab689bf ("docs: add asm type annotation") to
sibling packages missing the conventional trailing comment on
asm.js-style integer coercions.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EPpEJXtCEJjRk6CrC8bZv9
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
constants/float16/abs-mask $\\color{green}56/56$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}0/0$
$\\color{green}+100.00\\%$
$\\color{green}56/56$
$\\color{green}+100.00\\%$
constants/float16/num-exponent-bits $\\color{green}47/47$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}0/0$
$\\color{green}+100.00\\%$
$\\color{green}47/47$
$\\color{green}+100.00\\%$
constants/float16/num-significand-bits $\\color{green}47/47$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}0/0$
$\\color{green}+100.00\\%$
$\\color{green}47/47$
$\\color{green}+100.00\\%$
constants/float16/sign-mask $\\color{green}56/56$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}0/0$
$\\color{green}+100.00\\%$
$\\color{green}56/56$
$\\color{green}+100.00\\%$
constants/float32/abs-mask $\\color{green}56/56$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}0/0$
$\\color{green}+100.00\\%$
$\\color{green}56/56$
$\\color{green}+100.00\\%$
constants/float32/sign-mask $\\color{green}56/56$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}0/0$
$\\color{green}+100.00\\%$
$\\color{green}56/56$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Planeshifter marked this pull request as ready for review August 4, 2026 14:11
@Planeshifter
Planeshifter requested review from a team and kgryte August 4, 2026 14:11
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants