Fix silent failure in BrowserWebDriverContainer#getSeleniumAddress - #11958
Open
dev-xong wants to merge 1 commit into
Open
Fix silent failure in BrowserWebDriverContainer#getSeleniumAddress#11958dev-xong wants to merge 1 commit into
dev-xong wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix silent failure in BrowserWebDriverContainer#getSeleniumAddress
What does this PR do?
Fixed the
// TODOleft inBrowserWebDriverContainer#getSeleniumAddress().The existing code caught
MalformedURLExceptionand only callede.printStackTrace(), returningnull:This PR wraps the exception in
ContainerLaunchExceptionand throws it immediately, matching the existing error-handling pattern already used elsewhere in this class (e.g. for temp directory creation failures):The identical duplicated code in
org.testcontainers.selenium.BrowserWebDriverContaineris fixed the same way.